Skip to content

Migrate generic dialog-box to ha-wa-dialog #27669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Migrate generic dialog-box to ha-wa-dialog #27669

wants to merge 2 commits into from
+31 −19

Conversation

@timmo001
Copy link
Member

@timmo001 timmo001 commented Oct 27, 2025 •
edited
Loading

Breaking change

Proposed change

This changes a lot of UI areas, quite a bit of testing will be needed here. Not found anything so far that will cause issues, but some dialogs may have special setups (these should probably not use the generic dialog anyway)

Only differences found so far are dialogs now use the standard default width, which standardizes the varying dialog size based on the amount of content/text etc.

From image image image image

Exit unsaved scene editor:
image

To image image image image

Exit unsaved scene editor:
image

Areas affected

This was generated via a script on 2025-10-27

File Count Functions Used
src/panels/config/integrations/integration-panels/thread/thread-config-panel.ts 14 showAlertDialog,showConfirmationDialog, showPromptDialog
src/panels/config/integrations/ha-config-entry-row.ts 11 showAlertDialog,showConfirmationDialog, showPromptDialog
src/panels/config/automation/ha-automation-picker.ts 11 showAlertDialog,showConfirmationDialog
hassio/src/ingress-view/hassio-ingress-view.ts 10 showAlertDialog,showConfirmationDialog
hassio/src/addon-view/info/hassio-addon-info.ts 10 showAlertDialog,showConfirmationDialog
src/panels/config/script/ha-script-picker.ts 8 showAlertDialog,showConfirmationDialog
src/panels/config/entities/ha-config-entities.ts 8 showAlertDialog,showConfirmationDialog
hassio/src/system/hassio-supervisor-info.ts 8 showAlertDialog,showConfirmationDialog
hassio/src/system/hassio-host-info.ts 8 showAlertDialog,showConfirmationDialog, showPromptDialog
src/panels/lovelace/hui-editor.ts 7 showAlertDialog,showConfirmationDialog
src/panels/config/helpers/ha-config-helpers.ts 7 showAlertDialog,showConfirmationDialog
src/panels/profile/ha-refresh-tokens-card.ts 6 showAlertDialog,showConfirmationDialog
src/panels/lovelace/editor/view-editor/hui-dialog-edit-view.ts 6 showAlertDialog,showConfirmationDialog
src/panels/config/scene/ha-scene-editor.ts 6 showAlertDialog,showConfirmationDialog
src/panels/config/scene/ha-scene-dashboard.ts 6 showAlertDialog,showConfirmationDialog
src/panels/config/person/dialog-person-detail.ts 6 showAlertDialog,showConfirmationDialog, showPromptDialog
src/panels/config/integrations/ha-config-entry-device-row.ts 6 showAlertDialog,showConfirmationDialog
src/panels/config/entities/entity-registry-settings-editor.ts 6 showAlertDialog,showConfirmationDialog
src/panels/config/devices/ha-config-device-page.ts 6 showAlertDialog,showConfirmationDialog
src/panels/config/users/dialog-user-detail.ts 5 showAlertDialog,showPromptDialog
src/panels/config/integrations/integration-panels/matter/matter-config-dashboard.ts 5 showPromptDialog
src/panels/config/blueprint/ha-blueprint-overview.ts 5 showAlertDialog,showConfirmationDialog
src/panels/config/automation/ha-automation-editor.ts 5 showAlertDialog,showConfirmationDialog
hassio/src/dialogs/backup/dialog-hassio-backup.ts 5 showAlertDialog,showConfirmationDialog
src/panels/profile/ha-long-lived-access-tokens-card.ts 4 showAlertDialog,showConfirmationDialog, showPromptDialog
src/panels/lovelace/hui-root.ts 4 showAlertDialog,showConfirmationDialog
src/panels/config/script/ha-script-editor.ts 4 showAlertDialog,showConfirmationDialog
src/panels/config/lovelace/resources/ha-config-lovelace-resources.ts 4 showAlertDialog,showConfirmationDialog
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-config-dashboard.ts 4 showAlertDialog
src/panels/config/integrations/ha-config-integrations-dashboard.ts 4 showAlertDialog,showConfirmationDialog
src/panels/config/energy/components/ha-energy-grid-settings.ts 4 showAlertDialog,showConfirmationDialog
src/panels/config/devices/ha-config-devices-dashboard.ts 4 showAlertDialog,showConfirmationDialog
src/panels/config/backup/ha-config-backup-backups.ts 4 showAlertDialog,showConfirmationDialog
src/dialogs/config-flow/dialog-data-entry-flow.ts 4 showAlertDialog
src/components/ha-picture-upload.ts 4 showAlertDialog
hassio/src/update-available/update-available-card.ts 4 showAlertDialog
src/panels/config/storage/dialog-move-datadisk.ts 3 showAlertDialog
src/panels/config/network/supervisor-network.ts 3 showAlertDialog,showConfirmationDialog
src/panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-update-firmware-node.ts 3 showAlertDialog,showConfirmationDialog
src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts 3 showAlertDialog
src/panels/config/integrations/dialog-add-integration.ts 3 showAlertDialog,showConfirmationDialog
src/panels/config/entities/entity-registry-settings.ts 3 showAlertDialog,showConfirmationDialog
src/panels/config/cloud/login/cloud-login.ts 3 showAlertDialog,showConfirmationDialog, showPromptDialog
src/panels/config/cloud/account/cloud-account.ts 3 showAlertDialog,showConfirmationDialog
src/panels/config/automation/condition/ha-automation-condition-row.ts 3 showAlertDialog,showPromptDialog
src/panels/config/automation/action/ha-automation-action-row.ts 3 showAlertDialog,showPromptDialog
src/panels/config/application_credentials/ha-config-application-credentials.ts 3 showAlertDialog,showConfirmationDialog
src/dialogs/restart/dialog-restart.ts 3 showAlertDialog,showConfirmationDialog
src/data/regenerate_entity_ids.ts 3 showAlertDialog,showConfirmationDialog
src/common/integrations/protocolIntegrationPicked.ts 3 showConfirmationDialog
hassio/src/dialogs/network/dialog-hassio-network.ts 3 showAlertDialog,showConfirmationDialog
hassio/src/backups/hassio-backups.ts 3 showAlertDialog,showConfirmationDialog
src/panels/todo/ha-panel-todo.ts 2 showAlertDialog,showConfirmationDialog
src/panels/profile/ha-change-password-card.ts 2 showAlertDialog,showConfirmationDialog
src/panels/media-browser/ha-panel-media-browser.ts 2 showAlertDialog
src/panels/lovelace/editor/add-entities-to-view.ts 2 showAlertDialog
src/panels/lovelace/components/hui-card-options.ts 2 showAlertDialog,showPromptDialog
src/panels/history/ha-panel-history.ts 2 showAlertDialog
src/panels/energy/cards/energy-setup-wizard-card.ts 2 showAlertDialog
src/panels/developer-tools/template/developer-tools-template.ts 2 showConfirmationDialog
src/panels/config/zone/ha-config-zone.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/voice-assistants/ha-config-voice-assistants-expose.ts 2 showConfirmationDialog
src/panels/config/voice-assistants/debug/assist-pipeline-run-debug.ts 2 showAlertDialog,showPromptDialog
src/panels/config/voice-assistants/debug/assist-pipeline-debug.ts 2 showAlertDialog
src/panels/config/voice-assistants/assist-pref.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/tags/ha-config-tags.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/repairs/dialog-system-information.ts 2 showAlertDialog
src/panels/config/person/ha-config-person.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/labels/ha-config-labels.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/integrations/integration-panels/matter/dialog-matter-manage-fabrics.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/integrations/ha-disabled-config-entry-card.ts 2 showAlertDialog
src/panels/config/integrations/ha-config-sub-entry-row.ts 2 showConfirmationDialog,showPromptDialog
src/panels/config/integrations/ha-config-integration-page.ts 2 showAlertDialog
src/panels/config/energy/components/ha-energy-water-settings.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/energy/components/ha-energy-solar-settings.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/energy/components/ha-energy-gas-settings.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/energy/components/ha-energy-device-settings.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/energy/components/ha-energy-battery-settings.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/devices/device-detail/integration-elements/zwave_js/device-actions.ts 2 showConfirmationDialog
src/panels/config/cloud/login/cloud-login-panel.ts 2 showAlertDialog,showConfirmationDialog
src/panels/config/cloud/account/dialog-cloud-tts-try.ts 2 showAlertDialog
src/panels/config/cloud/account/cloud-tts-pref.ts 2 showAlertDialog
src/panels/config/backup/helper/download_backup.ts 2 showAlertDialog
src/panels/config/automation/trigger/ha-automation-trigger-row.ts 2 showAlertDialog,showPromptDialog
src/panels/config/automation/sidebar/ha-automation-sidebar-condition.ts 2 showAlertDialog
src/panels/config/areas/ha-config-areas-dashboard.ts 2 showAlertDialog,showConfirmationDialog
src/dialogs/voice-assistant-setup/cloud/cloud-step-signin.ts 2 showAlertDialog,showPromptDialog
src/dialogs/tts-try/dialog-tts-try.ts 2 showAlertDialog
src/dialogs/config-flow/step-flow-create-entry.ts 2 showAlertDialog
src/components/ha-assist-chat.ts 2 showAlertDialog
hassio/src/system/hassio-core-info.ts 2 showAlertDialog,showConfirmationDialog
hassio/src/dialogs/suggestAddonRestart.ts 2 showAlertDialog,showConfirmationDialog
hassio/src/dialogs/registries/dialog-hassio-registries.ts 2 showAlertDialog
hassio/src/components/hassio-upload-backup.ts 2 showAlertDialog
src/state/disconnect-toast-mixin.ts 1 showAlertDialog
src/panels/todo/dialog-todo-item-editor.ts 1 showConfirmationDialog
src/panels/profile/ha-profile-section-general.ts 1 showConfirmationDialog
src/panels/profile/ha-mfa-modules-card.ts 1 showConfirmationDialog
src/panels/media-browser/ha-bar-media-player.ts 1 showAlertDialog
src/panels/lovelace/heading-badges/hui-error-heading-badge.ts 1 showAlertDialog
src/panels/lovelace/editor/view-header/hui-dialog-edit-view-header.ts 1 showAlertDialog
src/panels/lovelace/editor/section-editor/hui-dialog-edit-section.ts 1 showAlertDialog
src/panels/lovelace/editor/hui-picture-elements-card-row-editor.ts 1 showConfirmationDialog
src/panels/lovelace/editor/conditions/ha-card-condition-editor.ts 1 showAlertDialog
src/panels/lovelace/editor/card-editor/hui-dialog-edit-card.ts 1 showConfirmationDialog
src/panels/lovelace/editor/badge-editor/hui-dialog-edit-badge.ts 1 showConfirmationDialog
src/panels/lovelace/components/hui-section-edit-mode.ts 1 showConfirmationDialog
src/panels/lovelace/common/handle-action.ts 1 showConfirmationDialog
src/panels/lovelace/common/confirm-action.ts 1 showConfirmationDialog
src/panels/lovelace/cards/hui-todo-list-card.ts 1 showConfirmationDialog
src/panels/lovelace/badges/hui-error-badge.ts 1 showAlertDialog
src/panels/developer-tools/statistics/dialog-statistics-fix.ts 1 showAlertDialog
src/panels/developer-tools/statistics/dialog-statistics-adjust-sum.ts 1 showAlertDialog
src/panels/developer-tools/statistics/developer-tools-statistics.ts 1 showConfirmationDialog
src/panels/developer-tools/state/developer-tools-state.ts 1 showAlertDialog
src/panels/developer-tools/event/developer-tools-event.ts 1 showAlertDialog
src/panels/config/voice-assistants/debug/assist-render-pipeline-run.ts 1 showAlertDialog
src/panels/config/users/ha-config-users.ts 1 showConfirmationDialog
src/panels/config/storage/ha-config-section-storage.ts 1 showAlertDialog
src/panels/config/script/ha-script-trace.ts 1 showAlertDialog
src/panels/config/network/supervisor-hostname.ts 1 showAlertDialog
src/panels/config/lovelace/dashboards/ha-config-lovelace-dashboards.ts 1 showConfirmationDialog
src/panels/config/logs/ha-config-logs.ts 1 showAlertDialog
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-provisioned.ts 1 showConfirmationDialog
src/panels/config/integrations/integration-panels/zwave_js/zwave_js-node-config.ts 1 showConfirmationDialog
src/panels/config/integrations/integration-panels/zwave_js/dialog-zwave_js-hard-reset-controller.ts 1 showConfirmationDialog
src/panels/config/integrations/integration-panels/zha/zha-device-card.ts 1 showAlertDialog
src/panels/config/integrations/integration-panels/zha/dialog-zha-change-channel.ts 1 showAlertDialog
src/panels/config/integrations/ha-ignored-config-entry-card.ts 1 showConfirmationDialog
src/panels/config/integrations/ha-config-flow-card.ts 1 showConfirmationDialog
src/panels/config/helpers/forms/ha-input_select-form.ts 1 showConfirmationDialog
src/panels/config/hardware/dialog-hardware-available.ts 1 showAlertDialog
src/panels/config/entities/editor-tabs/settings/entity-settings-helper-tab.ts 1 showConfirmationDialog
src/panels/config/devices/device-detail/integration-elements/zha/device-actions.ts 1 showConfirmationDialog
src/panels/config/core/ha-config-section-updates.ts 1 showAlertDialog
src/panels/config/core/ha-config-section-general.ts 1 showConfirmationDialog
src/panels/config/cloud/dialog-manage-cloudhook/dialog-manage-cloudhook.ts 1 showConfirmationDialog
src/panels/config/backup/ha-config-backup-location.ts 1 showConfirmationDialog
src/panels/config/backup/ha-config-backup-details.ts 1 showConfirmationDialog
src/panels/config/backup/dialogs/dialog-upload-backup.ts 1 showAlertDialog
src/panels/config/backup/components/overview/ha-backup-overview-summary.ts 1 showAlertDialog
src/panels/config/automation/trigger/types/ha-automation-trigger-conversation.ts 1 showConfirmationDialog
src/panels/config/automation/option/ha-automation-option-row.ts 1 showPromptDialog
src/panels/config/automation/ha-automation-trace.ts 1 showAlertDialog
src/panels/config/areas/ha-config-area-page.ts 1 showConfirmationDialog
src/panels/config/areas/dialog-area-registry-detail.ts 1 showConfirmationDialog
src/onboarding/restore-backup/onboarding-restore-backup-upload.ts 1 showAlertDialog
src/onboarding/onboarding-location.ts 1 showConfirmationDialog
src/dialogs/voice-assistant-setup/voice-assistant-setup-step-area.ts 1 showAlertDialog
src/dialogs/sidebar/dialog-edit-sidebar.ts 1 showConfirmationDialog
src/dialogs/quick-bar/ha-quick-bar.ts 1 showConfirmationDialog
src/dialogs/more-info/controls/more-info-update.ts 1 showAlertDialog
src/dialogs/more-info/components/lights/ha-more-info-light-favorite-colors.ts 1 showConfirmationDialog
src/dialogs/config-entry-system-options/dialog-config-entry-system-options.ts 1 showAlertDialog
src/data/update.ts 1 showAlertDialog
src/components/media-player/ha-media-upload-button.ts 1 showAlertDialog
src/components/media-player/ha-media-player-browse.ts 1 showAlertDialog
src/components/media-player/dialog-media-manage.ts 1 showConfirmationDialog
src/components/ha-selector/ha-selector-file.ts 1 showAlertDialog
src/components/ha-push-notifications-toggle.ts 1 showPromptDialog
src/components/ha-label-picker.ts 1 showAlertDialog
src/components/ha-floor-picker.ts 1 showAlertDialog
src/components/ha-filter-categories.ts 1 showConfirmationDialog
src/components/ha-area-picker.ts 1 showAlertDialog
src/components/buttons/ha-call-service-button.ts 1 showConfirmationDialog
landing-page/src/components/landing-page-network.ts 1 showAlertDialog
hassio/src/dialogs/datadisk/dialog-hassio-datadisk.ts 1 showAlertDialog
hassio/src/dialogs/backup/dialog-hassio-create-backup.ts 1 showAlertDialog
hassio/src/dashboard/hassio-dashboard.ts 1 showAlertDialog
hassio/src/addon-view/hassio-addon-dashboard.ts 1 showConfirmationDialog
hassio/src/addon-view/config/hassio-addon-config.ts 1 showConfirmationDialog
hassio/src/addon-store/hassio-addon-store.ts 1 showAlertDialog

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration



Additional information



    

  • This PR fixes or closes issue: fixes #
    • 

  • This PR is related to issue or discussion:
    • 

  • Link to documentation pull request:
    • 



Checklist



    

  •  The code change is tested and works locally.
    • 

  •  There is no commented out code in this PR.
    • 

  •  Tests have been added to verify that the new code works.
    • 



If user exposed functionality or configuration variables are added/changed:



    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



          

        
      




  




      

       
            



      

  
            







      

  
        

  

        

  timmo001
  

  
            

              
                    timmo001
  

              

              commented


              
                  
                    Oct 27, 2025
                  
              
              
            


            



                
    View reviewed changes
  


            






      

  
  
  
            
  
    
    

      
      
          
  
            
  
    
    


  




  








  








      

  
          

  
  

  
      @timmo001
  timmo001


        marked this pull request as ready for review

    October 27, 2025 14:22    
    









      

  
        





      

  
          

  
  

  
      @timmo001
  timmo001


        force-pushed
    the
        
      
  ha-wa-dialog-generic


    
 branch
    from
    901d525    to
    1aa55b3      
    Compare
  



    October 28, 2025 10:15    
    













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    

    No reviews






    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    cla-signed

  

    hacktoberfest









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      2 participants
    

    

        
          @timmo001